Skip to content

fix(ttid/ttfd): Add frame data to ttid/ttfd spans #4871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: antonis/appstart-frames
Choose a base branch
from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented May 29, 2025

Based on: #4865

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add frame data to ttid/ttfd spans ([#4871](https://github.com/getsentry/sentry-react-native/pull/4871))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 108c3ec

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 447.30 ms 440.00 ms -7.30 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Baseline results on branch: antonis/appstart-frames

Startup times

Revision Plain With Sentry Diff
11da461 418.00 ms 415.34 ms -2.66 ms
2d71b61 403.80 ms 411.15 ms 7.36 ms

App size

Revision Plain With Sentry Diff
11da461 17.75 MiB 20.15 MiB 2.40 MiB
2d71b61 17.75 MiB 20.15 MiB 2.40 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.98 ms 1229.58 ms 0.60 ms
Size 2.63 MiB 3.78 MiB 1.15 MiB

Baseline results on branch: antonis/appstart-frames

Startup times

Revision Plain With Sentry Diff
2d71b61+dirty 1208.33 ms 1211.53 ms 3.20 ms
11da461+dirty 1217.33 ms 1228.90 ms 11.56 ms

App size

Revision Plain With Sentry Diff
2d71b61+dirty 2.63 MiB 3.78 MiB 1.14 MiB
11da461+dirty 2.63 MiB 3.78 MiB 1.14 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 418.76 ms 412.37 ms -6.39 ms
Size 7.15 MiB 8.42 MiB 1.27 MiB

Baseline results on branch: antonis/appstart-frames

Startup times

Revision Plain With Sentry Diff
11da461+dirty 413.22 ms 438.36 ms 25.14 ms
2d71b61+dirty 406.57 ms 393.79 ms -12.78 ms

App size

Revision Plain With Sentry Diff
11da461+dirty 7.15 MiB 8.42 MiB 1.26 MiB
2d71b61+dirty 7.15 MiB 8.42 MiB 1.26 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.45 ms 1217.45 ms -4.00 ms
Size 3.19 MiB 4.35 MiB 1.16 MiB

Baseline results on branch: antonis/appstart-frames

Startup times

Revision Plain With Sentry Diff
2d71b61+dirty 1220.98 ms 1222.50 ms 1.52 ms
11da461+dirty 1232.37 ms 1233.33 ms 0.97 ms

App size

Revision Plain With Sentry Diff
2d71b61+dirty 3.19 MiB 4.34 MiB 1.16 MiB
11da461+dirty 3.19 MiB 4.34 MiB 1.16 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant