Skip to content

Kw-remove-sythetic-default-imports #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Apr 15, 2025

This flag is not necessary, we are not importing non existing default anywhere in the SDK code.

#skip-changelog

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.29 ms 431.84 ms 1.55 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9da5c4e 478.08 ms 467.46 ms -10.63 ms

App size

Revision Plain With Sentry Diff
9da5c4e 17.75 MiB 20.16 MiB 2.41 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.90 ms 1216.08 ms 3.18 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9da5c4e+dirty 1215.41 ms 1226.38 ms 10.97 ms

App size

Revision Plain With Sentry Diff
9da5c4e+dirty 3.19 MiB 4.33 MiB 1.14 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.15 ms 1235.38 ms 22.23 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9da5c4e+dirty 1231.84 ms 1235.49 ms 3.65 ms

App size

Revision Plain With Sentry Diff
9da5c4e+dirty 2.63 MiB 3.76 MiB 1.13 MiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit a852e28 into v7 Apr 15, 2025
66 of 70 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-remove-sythetic-default-imports branch April 15, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants