-
Notifications
You must be signed in to change notification settings - Fork 548
feat(logs): Forward extra from logger as attributes #4374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 6 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
6cf2671
to
4cee7d1
Compare
tests/test_logs.py
Outdated
logs = envelopes_to_logs(envelopes) | ||
assert logs[0]["attributes"]["foo"] == "bar" | ||
assert logs[0]["attributes"]["numeric"] == 42 | ||
assert logs[0]["attributes"]["more_complex"] == '{"nested": "data"}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you assert the attributes is equal to something, to make sure we aren't adding garbage default attributes from the record?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with 1b73d4c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok
resolves https://linear.app/getsentry/issue/LOGS-101