Skip to content

tests: Move aiohttp under toxgen #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 23, 2025
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 22, 2025

Depends on #4323

Copy link

codecov bot commented Apr 22, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23556 1 23555 5870
View the top 1 failed test(s) by shortest run time
tests.test_utils test_get_current_thread_meta_main_thread
Stack Traces | 0.007s run time
tests/test_utils.py:901: in test_get_current_thread_meta_main_thread
    thread.join()
.../hostedtoolcache/Python/3.10.17............/x64/lib/python3.10/threading.py:1092: in join
    if self is current_thread():
.../hostedtoolcache/Python/3.10.17............/x64/lib/python3.10/unittest/mock.py:1114: in __call__
    return self._mock_call(*args, **kwargs)
.../hostedtoolcache/Python/3.10.17............/x64/lib/python3.10/unittest/mock.py:1118: in _mock_call
    return self._execute_mock_call(*args, **kwargs)
.../hostedtoolcache/Python/3.10.17............/x64/lib/python3.10/unittest/mock.py:1175: in _execute_mock_call
    result = next(effect)
E   StopIteration

The above exception was the direct cause of the following exception:
.tox/py3.10-gevent/lib/python3.10....../site-packages/_pytest/runner.py:341: in from_call
    result: TResult | None = func()
.tox/py3.10-gevent/lib/python3.10....../site-packages/_pytest/runner.py:242: in <lambda>
    lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise
.tox/py3.10-gevent/lib/python3.10.../site-packages/pluggy/_hooks.py:513: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
.tox/py3.10-gevent/lib/python3.10.../site-packages/pluggy/_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
.tox/py3.10-gevent/lib/python3.10....../site-packages/_pytest/threadexception.py:92: in pytest_runtest_call
    yield from thread_exception_runtest_hook()
.tox/py3.10-gevent/lib/python3.10....../site-packages/_pytest/threadexception.py:68: in thread_exception_runtest_hook
    yield
.tox/py3.10-gevent/lib/python3.10....../site-packages/_pytest/unraisableexception.py:95: in pytest_runtest_call
    yield from unraisable_exception_runtest_hook()
.tox/py3.10-gevent/lib/python3.10....../site-packages/_pytest/unraisableexception.py:70: in unraisable_exception_runtest_hook
    yield
.tox/py3.10-gevent/lib/python3.10....../site-packages/_pytest/logging.py:846: in pytest_runtest_call
    yield from self._runtest_for(item, "call")
.tox/py3.10-gevent/lib/python3.10....../site-packages/_pytest/logging.py:829: in _runtest_for
    yield
.tox/py3.10-gevent/lib/python3.10.../site-packages/_pytest/capture.py:898: in pytest_runtest_call
    return (yield)
E   RuntimeError: generator raised StopIteration

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana changed the title tests: Migrate aiohttp under toxgen tests: Move aiohttp under toxgen Apr 22, 2025
@sentrivana sentrivana marked this pull request as ready for review April 22, 2025 15:16
@sentrivana sentrivana requested a review from a team as a code owner April 22, 2025 15:16
@sentrivana sentrivana changed the base branch from master to ivana/fix-toxgen April 23, 2025 08:07
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the tests are passing, I think this is good.

Base automatically changed from ivana/fix-toxgen to master April 23, 2025 08:54
@sentrivana sentrivana enabled auto-merge (squash) April 23, 2025 08:55
@sentrivana sentrivana merged commit 2c3776c into master Apr 23, 2025
139 of 140 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/migrate-aiohttp branch April 23, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants