Deprecation warning causing test failures in Sentry

[cmanallen]

How do you use Sentry?

Sentry Saas (sentry.io)

Version

2.21.0

Steps to Reproduce

Failing tests: https://github.com/getsentry/sentry/actions/runs/13311941884/job/37176515275?pr=85146

____________________________________________ ERROR at setup of test_composite_backend_does_not_recurse ____________________________________________
tests/sentry/metrics/test_minimetrics.py:48: in scope
    client=Client(
.venv/lib/python3.13/site-packages/sentry_sdk/client.py:269: in __init__
    self._init_impl()
.venv/lib/python3.13/site-packages/sentry_sdk/client.py:392: in _init_impl
    self.integrations = setup_integrations(
.venv/lib/python3.13/site-packages/sentry_sdk/integrations/__init__.py:197: in setup_integrations
    instance = integration_cls()
.venv/lib/python3.13/site-packages/sentry_sdk/integrations/celery/__init__.py:73: in __init__
    warnings.warn(
E   DeprecationWarning: The `propagate_traces` parameter is deprecated. Please use `trace_propagation_targets` instead.

There doesn't seem to be a way to avoid it:

sentry-python/sentry_sdk/integrations/celery/__init__.py

Lines 66 to 77 in dfd6cef

	def __init__(
	self,
	propagate_traces=True,
	monitor_beat_tasks=False,
	exclude_beat_tasks=None,
	):
	# type: (bool, bool, Optional[List[str]]) -> None
	warnings.warn(
	"The `propagate_traces` parameter is deprecated. Please use `trace_propagation_targets` instead.",
	DeprecationWarning,
	stacklevel=2,
	)

Previous release looked like this:

sentry-python/sentry_sdk/integrations/celery/__init__.py

Lines 64 to 73 in 4e0505e

	def __init__(
	self,
	propagate_traces=True,
	monitor_beat_tasks=False,
	exclude_beat_tasks=None,
	):
	# type: (bool, bool, Optional[List[str]]) -> None
	self.propagate_traces = propagate_traces
	self.monitor_beat_tasks = monitor_beat_tasks
	self.exclude_beat_tasks = exclude_beat_tasks

Expected Result

Tests do not fail due to a warning message or we can prevent the warning in some way through configuration.

Actual Result

Tests fail.

[cmanallen]

According to Anthony tests will fail in Sentry if a Python warning is emitted. Since we're using warnings.warn this seems like the issue.

[szokeasaurusrex]

Hi @cmanallen, this problem should likely be addressed in Sentry.

We are deprecating propagate_traces in favor of trace_propagation_targets, since we intend to remove propagation_traces. If the deprecation warning is causing test failures in Sentry, then the warnings are having the desired effect. The warnings are meant to prompt you to stop using the deprecated functionality.

So, you should stop using the deprecated functionality in Sentry, and use the replacement trace_propagation_targets, instead. Alternatively, you could choose to ignore this warning in the tests, but then you'll have to fix the removal with the new major.

Is there a reason you cannot switch to trace_propagation_targets? Does the new API lack something the old API offered? If so, we could reconsider our decision to deprecate and remove this option. But, I don't think we should remove a deprecation warning simply to make tests in Sentry pass.

[szokeasaurusrex]

Please disregard the previous comment – as @sl0thentr0py pointed out on your PR, we accidentally deprecated more that we had meant to.

We should undeprecate only the Celery deprecation warning. The other one should stay. Please edit your PR accordingly