fix(astro): Avoid RegExp creation during route interpolation #9815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Added more detailed description after publishing Security Adivsory:
This PR fixes a security vulnerability in the
@sentry/astro
SDK. It fixes to CVE-2023-50249.Summary: Previously, under certain conditions, we compiled a new
RegExp
for user-entered URL parameter values to interpolate a route name when starting a transaction. Unfortunately, we did not escape these parameter values, meaning that with the right regex and parameter combination, projects using our Astro SDK were exposed to a ReDos vulnerability.For more information and to see if you were affected by the vulnerability (there are criteria to be affected), please refer to the security advisory.
This PR replaces the route interpolation that was previously based on compiling a
RegExp
for each parameter value:Instead of this dynamic regex creation, we now