Skip to content

feat(node): Use worker thread for ANR detection #9789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/node-integration-tests/suites/anr/basic-session.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ const Sentry = require('@sentry/node');

const { transport } = require('./test-transport.js');

// close both processes after 5 seconds
setTimeout(() => {
process.exit();
}, 5000);
}, 10000);

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down
3 changes: 1 addition & 2 deletions packages/node-integration-tests/suites/anr/basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ const Sentry = require('@sentry/node');

const { transport } = require('./test-transport.js');

// close both processes after 5 seconds
setTimeout(() => {
process.exit();
}, 5000);
}, 10000);

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down
3 changes: 1 addition & 2 deletions packages/node-integration-tests/suites/anr/basic.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ import * as Sentry from '@sentry/node';

const { transport } = await import('./test-transport.js');

// close both processes after 5 seconds
setTimeout(() => {
process.exit();
}, 5000);
}, 10000);

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down
3 changes: 1 addition & 2 deletions packages/node-integration-tests/suites/anr/forked.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ const Sentry = require('@sentry/node');

const { transport } = require('./test-transport.js');

// close both processes after 5 seconds
setTimeout(() => {
process.exit();
}, 5000);
}, 10000);

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down
47 changes: 25 additions & 22 deletions packages/node-integration-tests/suites/anr/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ function parseJsonLines<T extends unknown[]>(input: string, expected: number): T

describe('should report ANR when event loop blocked', () => {
test('CJS', done => {
// The stack trace is different when node < 12
const testFramesDetails = NODE_VERSION >= 12;
if (NODE_VERSION < 12) {
done();
return;
}

expect.assertions(testFramesDetails ? 7 : 5);
expect.assertions(9);

const testScriptPath = path.resolve(__dirname, 'basic.js');

Expand All @@ -41,10 +43,11 @@ describe('should report ANR when event loop blocked', () => {
expect(event.exception?.values?.[0].value).toEqual('Application Not Responding for at least 200 ms');
expect(event.exception?.values?.[0].stacktrace?.frames?.length).toBeGreaterThan(4);

if (testFramesDetails) {
expect(event.exception?.values?.[0].stacktrace?.frames?.[2].function).toEqual('?');
expect(event.exception?.values?.[0].stacktrace?.frames?.[3].function).toEqual('longWork');
}
expect(event.exception?.values?.[0].stacktrace?.frames?.[2].function).toEqual('?');
expect(event.exception?.values?.[0].stacktrace?.frames?.[3].function).toEqual('longWork');

expect(event.contexts?.trace?.trace_id).toBeDefined();
expect(event.contexts?.trace?.span_id).toBeDefined();

done();
});
Expand All @@ -66,7 +69,7 @@ describe('should report ANR when event loop blocked', () => {
expect(event.exception?.values?.[0].mechanism).toEqual({ type: 'ANR' });
expect(event.exception?.values?.[0].type).toEqual('ApplicationNotResponding');
expect(event.exception?.values?.[0].value).toEqual('Application Not Responding for at least 200 ms');
expect(event.exception?.values?.[0].stacktrace?.frames?.length).toBeGreaterThan(4);
expect(event.exception?.values?.[0].stacktrace?.frames?.length).toBeGreaterThanOrEqual(4);
expect(event.exception?.values?.[0].stacktrace?.frames?.[2].function).toEqual('?');
expect(event.exception?.values?.[0].stacktrace?.frames?.[3].function).toEqual('longWork');

Expand All @@ -75,10 +78,12 @@ describe('should report ANR when event loop blocked', () => {
});

test('With session', done => {
// The stack trace is different when node < 12
const testFramesDetails = NODE_VERSION >= 12;
if (NODE_VERSION < 12) {
done();
return;
}

expect.assertions(testFramesDetails ? 9 : 7);
expect.assertions(9);

const testScriptPath = path.resolve(__dirname, 'basic-session.js');

Expand All @@ -90,10 +95,8 @@ describe('should report ANR when event loop blocked', () => {
expect(event.exception?.values?.[0].value).toEqual('Application Not Responding for at least 200 ms');
expect(event.exception?.values?.[0].stacktrace?.frames?.length).toBeGreaterThan(4);

if (testFramesDetails) {
expect(event.exception?.values?.[0].stacktrace?.frames?.[2].function).toEqual('?');
expect(event.exception?.values?.[0].stacktrace?.frames?.[3].function).toEqual('longWork');
}
expect(event.exception?.values?.[0].stacktrace?.frames?.[2].function).toEqual('?');
expect(event.exception?.values?.[0].stacktrace?.frames?.[3].function).toEqual('longWork');

expect(session.status).toEqual('abnormal');
expect(session.abnormal_mechanism).toEqual('anr_foreground');
Expand All @@ -103,10 +106,12 @@ describe('should report ANR when event loop blocked', () => {
});

test('from forked process', done => {
// The stack trace is different when node < 12
const testFramesDetails = NODE_VERSION >= 12;
if (NODE_VERSION < 12) {
done();
return;
}

expect.assertions(testFramesDetails ? 7 : 5);
expect.assertions(7);

const testScriptPath = path.resolve(__dirname, 'forker.js');

Expand All @@ -118,10 +123,8 @@ describe('should report ANR when event loop blocked', () => {
expect(event.exception?.values?.[0].value).toEqual('Application Not Responding for at least 200 ms');
expect(event.exception?.values?.[0].stacktrace?.frames?.length).toBeGreaterThan(4);

if (testFramesDetails) {
expect(event.exception?.values?.[0].stacktrace?.frames?.[2].function).toEqual('?');
expect(event.exception?.values?.[0].stacktrace?.frames?.[3].function).toEqual('longWork');
}
expect(event.exception?.values?.[0].stacktrace?.frames?.[2].function).toEqual('?');
expect(event.exception?.values?.[0].stacktrace?.frames?.[3].function).toEqual('longWork');

done();
});
Expand Down
55 changes: 0 additions & 55 deletions packages/node/src/anr/debugger.ts

This file was deleted.

Loading