Skip to content

ref(core): Introduce protected _getBreadcrumbs() on scope #8961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

ref(core): Introduce protected _getBreadcrumbs() on scope #8961

merged 2 commits into from
Sep 7, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 6, 2023

Making it easier to potentially change this e.g. for POTEL.

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad September 6, 2023 13:34
@mydea mydea self-assigned this Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.37 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.26 KB (+0.05% 🔺)
@sentry/browser - Webpack (gzipped) 21.87 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.89 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.2 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.2 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.82 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.11 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.75 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.1 KB (+0.05% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.39 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 21.9 KB (+0.05% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.24 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.83 KB (+0.03% 🔺)

lforst
lforst reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is public API and removing it (even when in the process of doing a major) is usually a lot of pain (in regards to documentation - migration guides etc), would you care to elaborate why we need this?

@mydea
Copy link
Member Author

mydea commented Sep 7, 2023

yeah, sure, sorry, could have def. elaborated more on this.

For POTEL I want to (experimentally) overwrite this to have a different logic to get the breadcrumbs for a scope. I figured it would be the cleanest solution to expose this as a function (similar to others we already have like this on the scope, like getAttachments() etc). If we do not like this being public API I could also make it a protected function, which should be good enough to be able to overwrite it in a subclass 🤔

@mydea
ref(core): Introduce getBreadcrumbs() on scope to abstract this away
a68bf32 
Making it easier to potentially change this e.g. for POTEL.
@mydea mydea force-pushed the fn/scope-breadcrumbs branch 2 times, most recently from e8ed426 to a68bf32 Compare September 7, 2023 08:42
@mydea mydea mentioned this pull request Sep 7, 2023
Merged
Lms24
Lms24 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If we do not like this being public API I could also make it a protected function, which should be good enough to be able to overwrite it in a subclass

No strong feeling but if it's not too much work then, let's do this. We can still make it public later on but reversing things is harder.

@mydea
Copy link
Member Author

mydea commented Sep 7, 2023

Updated this to protected _getBreadcrumbs() and removed it from types!

@mydea mydea changed the title ref(core): Introduce getBreadcrumbs() on scope to abstract this away ref(core): Introduce protected _getBreadcrumbs() on scope Sep 7, 2023
@mydea mydea enabled auto-merge (squash) September 7, 2023 09:45
@mydea mydea merged commit 4c17f6e into develop Sep 7, 2023
@mydea mydea deleted the fn/scope-breadcrumbs branch September 7, 2023 10:01
onurtemizkan pushed a commit that referenced this pull request Sep 7, 2023
@mydea @onurtemizkan
ref(core): Introduce protected _getBreadcrumbs() on scope (#8961)
d4fd921 
Making it easier to potentially change this e.g. for POTEL.
billyvg pushed a commit that referenced this pull request Sep 7, 2023
@mydea @billyvg
ref(core): Introduce protected _getBreadcrumbs() on scope (#8961)
6476af0 
Making it easier to potentially change this e.g. for POTEL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @lforst @Lms24