Skip to content

test(browser): Temporarily skip offline transport tests #7305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 1, 2023

Unfortunately, these tests are continuously flaky so we're disabling them temporarily until the flakes are resolved.

cc @timfish when you get back :)

ref #7079

@Lms24 Lms24 self-assigned this Mar 1, 2023
@Lms24 Lms24 requested review from a team, mydea and lforst and removed request for a team March 1, 2023 10:22
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Replay SDK metrics 🚀

    Plain +Sentry +Replay
Revision Value Value Diff Ratio Value Diff Ratio
LCP This PR 70abc37 81.75 ms 66.26 ms -15.49 ms -18.95 % 68.30 ms -13.45 ms -16.45 %
Previous dbd7a81 116.00 ms 148.94 ms +32.94 ms +28.40 % 214.37 ms +98.37 ms +84.80 %
CLS This PR 70abc37 0.00 ms 0.00 ms 0.00 ms 0.00 % 0.24 ms +0.23 ms +5059.44 %
Previous dbd7a81 0.06 ms 0.06 ms -0.00 ms -0.69 % 0.06 ms -0.00 ms -0.79 %
CPU This PR 70abc37 22.55 % 21.89 % -0.66 pp -2.92 % 38.04 % +15.49 pp +68.69 %
Previous dbd7a81 27.65 % 26.67 % -0.98 pp -3.55 % 34.33 % +6.68 pp +24.16 %
JS heap avg This PR 70abc37 3.5 MB 6.74 MB +3.24 MB +92.53 % 10.96 MB +7.46 MB +212.86 %
Previous dbd7a81 1.88 MB 2.31 MB +428.27 kB +22.80 % 3.52 MB +1.64 MB +87.53 %
JS heap max This PR 70abc37 3.92 MB 8.18 MB +4.25 MB +108.46 % 13.79 MB +9.87 MB +251.57 %
Previous dbd7a81 2.28 MB 2.68 MB +399.08 kB +17.47 % 4.1 MB +1.82 MB +79.65 %
netTx This PR 70abc37 0 B 333.2 kB +333.2 kB n/a 106.68 kB +106.68 kB n/a
Previous dbd7a81 0 B 0 B 0 B n/a 2.23 kB +2.23 kB n/a
netRx This PR 70abc37 20.97 kB 18.35 kB -2.62 kB -12.47 % 20.32 kB -641 B -3.06 %
Previous dbd7a81 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount This PR 70abc37 1 2 +1 +100.00 % 5 +4 +400.00 %
Previous dbd7a81 0 0 0 n/a 1 +1 n/a
netTime This PR 70abc37 675.11 ms 528.08 ms -147.03 ms -21.78 % 712.26 ms +37.15 ms +5.50 %
Previous dbd7a81 0.00 ms 0.00 ms 0.00 ms n/a 124.71 ms +124.71 ms n/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
dbd7a81+98.37 ms-0.00 ms+6.68 pp+1.64 MB+1.82 MB+2.23 kB+41 B+1+124.71 ms
dbd7a81+86.19 ms-0.00 ms+6.77 pp+1.58 MB+1.67 MB+2.23 kB+41 B+1+87.99 ms
67b0684+84.74 ms-0.00 ms+7.38 pp+1.7 MB+1.81 MB+2.23 kB+41 B+1+85.52 ms
4b95c04+57.56 ms-0.00 ms+7.94 pp+920.88 kB+1.05 MB+2.21 kB+41 B+1+90.32 ms
e60cd02+56.25 ms-0.00 ms+6.32 pp+927.44 kB+1.06 MB+2.21 kB+41 B+1+117.55 ms
e25c067+48.34 ms+0.00 ms+5.59 pp+926.37 kB+1.05 MB+2.22 kB+41 B+1+65.23 ms
b1b249b+43.88 ms+0.00 ms+4.80 pp+937.99 kB+1.05 MB+2.22 kB+41 B+1+111.56 ms
12e34d4+28.57 ms+0.00 ms+5.77 pp+930.12 kB+1.04 MB+2.26 kB+41 B+1+109.67 ms
c46c56c+65.45 ms-0.00 ms+5.38 pp+930.26 kB+1.07 MB+2.21 kB+41 B+1+91.29 ms
7f4c4ec+56.64 ms-0.00 ms+5.57 pp+927.42 kB+1.06 MB+2.21 kB+41 B+1+110.83 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 01 Mar 2023 10:46:23 GMT

@Lms24 Lms24 merged commit 3ba8e0b into develop Mar 1, 2023
@Lms24 Lms24 deleted the lms/tmp-skip-offline-transport-tests branch March 1, 2023 11:18
Lms24 added a commit that referenced this pull request Mar 1, 2023
Lms24 added a commit that referenced this pull request Mar 1, 2023
* Revert "test(browser): Temporarily skip offline transport tests (#7305)"
* test(core): Skip flaky offline transport test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants