test(replay): Fix flaky xhr/fetch request tests #7270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Lms24
force-pushed
the
lms/replay-pw-fix-flake-requests
branch
2 times, most recently
from
c6bd979 to
91fe0dd
Compare
change order of actions and awaiting requests use Promise.all in xhr test reduce flush mindelay, increase maxdelay explicitly await request response simplify waitForResponse skip tests on firefox cleanup test
Lms24
force-pushed
the
lms/replay-pw-fix-flake-requests
branch
from
6af894b to
b10e550
Compare
mydea
reviewed
Feb 28, 2023
| flushMinDelay: 500, | ||
| flushMaxDelay: 500, | ||
| useCompression: true, | ||
| flushMinDelay: 200, |
There was a problem hiding this comment.
Did we change these on purpose? 🤔 IMHO it would be good to leave this at the same value to better replicate the regular "default" experience, wdyt?
There was a problem hiding this comment.
Ahh I think this is just a leftover from experimenting. Will change, thanks!
There was a problem hiding this comment.
Actually, I'll test this with another 150x run just to be sure 😅
Lms24
changed the title
seems ok
Lms24
force-pushed
the
lms/replay-pw-fix-flake-requests
branch
from
28ec9fc to
44468e0
Compare
mydea
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #7267, a newly added replay test (#7044) for checking for the presence of XHR/fetch request spans was flaky on CI. I pinned this down to two reasons which this PR fixes:
Note: I ran these tests multiple times for 150 times per CI job and haven't observed flakes anymore.
closes #7267