ci: Move replay metrics into dedicated package #7115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @vaind |
|
Can we rename to something more specific so we don't re-use the namescape of |
mydea
force-pushed
the
fn/move-metrics
branch
from
6e275e6 to
1876736
Compare
|
I renamed it to |
mydea
force-pushed
the
fn/move-metrics
branch
from
1876736 to
95e7c3f
Compare
Lms24
approved these changes
Feb 10, 2023
| @@ -37,22 +37,6 @@ | |||
| "internalConsoleOptions": "openOnSessionStart", | |||
| "outputCapture": "std" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
l: I never used these launch scripts so my logaf is practically nonexistent but is there a particular reason to remove them?
There was a problem hiding this comment.
I was more thinking why we would need them 😅
Replay SDK metrics 🚀
develop |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| e60cd02 | +56.25 ms | -0.00 ms | +6.32 pp | +927.44 kB | +1.06 MB | +2.21 kB | +41 B | +1 | +117.55 ms |
| e25c067 | +48.34 ms | +0.00 ms | +5.59 pp | +926.37 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +65.23 ms |
| b1b249b | +43.88 ms | +0.00 ms | +4.80 pp | +937.99 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +111.56 ms |
| 12e34d4 | +28.57 ms | +0.00 ms | +5.77 pp | +930.12 kB | +1.04 MB | +2.26 kB | +41 B | +1 | +109.67 ms |
| c46c56c | +65.45 ms | -0.00 ms | +5.38 pp | +930.26 kB | +1.07 MB | +2.21 kB | +41 B | +1 | +91.29 ms |
| 7f4c4ec | +56.64 ms | -0.00 ms | +5.57 pp | +927.42 kB | +1.06 MB | +2.21 kB | +41 B | +1 | +110.83 ms |
| 00d2360 | +55.18 ms | +0.00 ms | +2.23 pp | +934.14 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +71.65 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Tue, 28 Feb 2023 09:56:06 GMT
Last updated: Tue, 28 Feb 2023 09:56:06 GMT
mydea
force-pushed
the
fn/move-metrics
branch
from
95e7c3f to
c3a2a90
Compare
size-limit report 📦
|
mydea
force-pushed
the
fn/move-metrics
branch
2 times, most recently
from
f48f598 to
17899df
Compare
mydea
force-pushed
the
fn/move-metrics
branch
from
17899df to
ddc3b05
Compare
|
Just FYI I also bumped playwright to 1.31.1 here, as I got some conflicts. cc @lforst @Lms24 @AbhiPrasad if you run into any playwright specific issues 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the replay metrics info
packages/metrics.It also removes the unused
demoapp inside of replay.Note that we seem to have a bug with the PR comment creation/update. We've seen it update "random" PRs, we suspect when the develop branch collects metrics.