Skip to content

ci: Fix CI failing on master #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 10, 2023
Merged

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jan 10, 2023

1. Remix failures

CI is failing on the newest remix version due to usage of the hammer operator: https://github.com/getsentry/sentry-javascript/actions/runs/3881841098/jobs/6621446961#step:6:1011

We assume this is a bug within the new remix release so we pin the version to a previous non-faulty one.

Issue in remix repo: remix-run/remix#5043

2. Playwright failures

Updating playwright seems to fix things?

@lforst lforst changed the title ci(remix): Pin remix version in integration tests ci: Fix CI failing on master Jan 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.64 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.05 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.3 KB (0%)

@lforst lforst requested a review from Lms24 January 10, 2023 10:23
@lforst lforst merged commit 10a80d5 into master Jan 10, 2023
@lforst lforst deleted the lforst-fix-remix-integration-test branch January 10, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants