ref(vue): Use string.repeat()
#6663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Lol, never saw this before xD. I think this should be fine. If users bundle their app and they want to support IE11, they could just polyfill String.repeat
Also, this is only used for creating a component "trace" (overloaded term...) in event.context.vue of error events, so the impact shouldn't be too drastic
size-limit report 📦
|
Yeah, I thought so as well. And we can save a few precious bytes ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled over this by accident, and was wondering what you thought about making use of the in-built
string.repeat()method there. This is not supported in IE11, but IMHO it is acceptable to fall back to just use the string once in that case, as it will only result in less-nice-looking nesting, not break. But not sure, maybe it is a bad idea, WDYT?