build: Update @typescript-eslint packages & fix resulting linting issues #6657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/update-eslint-typescript
branch
from
33c7d05 to
5af2e19
Compare
Lms24
approved these changes
Jan 5, 2023
mydea
force-pushed
the
fn/update-eslint-typescript
branch
from
5af2e19 to
0659290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates @typescript-eslint/parser & @typescript-eslint/eslint-plugin from 3.9.0 to 5.48.0.
This brings with it a few changes rules, which I've updated the code to accomodate.
The biggest change is that I've updated most places where we had
unbound-methoderrors. Now, I've marked the functions that can be passed in those places asthis: void, making clear that there is nothiscontext.