test(e2e): Allow lockfiles in E2E tests #5871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Oct 3, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "$schema": "../../test-recipe-schema.json", | |||
| "testApplicationName": "create-react-app", | |||
| "buildCommand": "yarn install && yarn build", | |||
| "buildCommand": "yarn install --no-lockfile && yarn build", | |||
There was a problem hiding this comment.
Doesn’t this mean it won’t read the lockfile?
There was a problem hiding this comment.
Yeah changed to --pure-lockfile instead which seems to do what we need here.
added 2 commits
October 3, 2022 09:35
AbhiPrasad
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to reduce E2E test flakiness as examined in this CI run by allowing lockfiles in E2E tests.