Skip to content

chore(nextjs): Move withSentry into withSentryAPI module #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Sep 22, 2022

This moves withSentry.ts (and its corresponding test file) to live alongside our other withSentryX wrappers. More specifically, it moves withSentry's types into a new wrappers/types file, and moves its functions into withSentryAPI, since withSentryAPI is becoming the primary wrapper and withSentry is becoming just a helper function.

Note: This is one step in a slightly larger reorganization I want to do in the nextjs SDK, now that it's matured a bit and we have a better idea of what files it needs to contain. For both ease of review and my own time management, I'm going to split the changes up over several PRs and do each as they become relevant and/or start to bug me enough that I fix them.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.47 KB (+0.22% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.16 KB (+0.14% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.06 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.08 KB (+0.13% 🔺)
@sentry/browser - Webpack (gzipped + minified) 19.85 KB (+0.2% 🔺)
@sentry/browser - Webpack (minified) 64.49 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped + minified) 19.88 KB (+0.2% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.73 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.93 KB (+0.2% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.33 KB (+0.07% 🔺)

@lobsterkatie lobsterkatie requested a review from lforst September 22, 2022 15:41
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-wrap-api-routes branch from 2afe509 to f7f8dbd Compare September 23, 2022 07:23
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-move-withSentry-to-wrappers-dir branch from 42dca39 to 48346c6 Compare September 23, 2022 07:41
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-wrap-api-routes branch from f7f8dbd to e1dbf7c Compare September 23, 2022 07:44
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-move-withSentry-to-wrappers-dir branch from 48346c6 to eaeffd6 Compare September 23, 2022 07:44
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-wrap-api-routes branch from e1dbf7c to 8ed7ea5 Compare September 23, 2022 20:07
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-move-withSentry-to-wrappers-dir branch from eaeffd6 to 34af026 Compare September 26, 2022 04:08
Base automatically changed from kmclb-nextjs-wrap-api-routes to master September 26, 2022 04:12
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-move-withSentry-to-wrappers-dir branch from 34af026 to e8f8a3d Compare September 26, 2022 04:14
@lobsterkatie lobsterkatie marked this pull request as ready for review September 26, 2022 04:40
@lobsterkatie lobsterkatie merged commit 8000012 into master Sep 26, 2022
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-move-withSentry-to-wrappers-dir branch September 26, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants