Skip to content

ref(tracing): Update long task description #5601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

ref(tracing): Update long task description #5601

merged 2 commits into from
Aug 18, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Aug 17, 2022 •
edited
Loading

Update the ui.long-task span description to explain what is happening while the span is occuring.

https://developer.mozilla.org/en-US/docs/Web/API/Long_Tasks_API

@AbhiPrasad
ref(tracing): Update long task description
c1fbeae 
Give more context about what the issue is.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.4 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.06 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.98 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 52.92 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.77 KB (0%)
@sentry/browser - Webpack (minified) 64.31 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.79 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.71 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.91 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.28 KB (+0.05% 🔺)

k-fish
k-fish approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@k-fish k-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the op + the description will help this be clearer, especially since it uses the same terminology as seen on the mdn docs etc. We can potentially add an explanation in the UI if we get questions about this and link out to docs.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) August 18, 2022 13:38
@AbhiPrasad AbhiPrasad merged commit dbbe0bd into master Aug 18, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-long-task-description branch August 18, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-fish k-fish k-fish approved these changes

@vladanpaunovic vladanpaunovic vladanpaunovic approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @k-fish @vladanpaunovic