Skip to content

ref(nextjs): Always use tsx parser in experimental function-wrapping loader #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Aug 10, 2022

The changes the experimental data-fetching-function-wrapping loader to always use the tsx parser, as it's capable of parsing jsx as well. This in turn allows us to simplify the makeAST function.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.38 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 59.99 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.96 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 52.88 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.73 KB (0%)
@sentry/browser - Webpack (minified) 64.21 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.75 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.16 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.79 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.04 KB (-0.02% 🔽)

@lobsterkatie lobsterkatie requested a review from lforst August 10, 2022 23:22
@lforst lforst force-pushed the kmclb-nextjs-always-use-tsx-parser-in-loader branch from 9eb9447 to c56188d Compare August 11, 2022 09:00
@lobsterkatie lobsterkatie force-pushed the kmclb-nextjs-always-use-tsx-parser-in-loader branch from c56188d to 9fe7f40 Compare August 11, 2022 22:53
@lobsterkatie lobsterkatie merged commit a6eee54 into master Aug 11, 2022
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-always-use-tsx-parser-in-loader branch August 11, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants