ref(test): Break up nextjs config tests #5541
Conversation
| exportedNextConfig: ExportedNextConfig, | ||
| userSentryWebpackPluginConfig?: Partial<SentryWebpackPluginOptions>, | ||
| ): NextConfigObject { | ||
| const sentrifiedConfig = withSentryConfig(exportedNextConfig, userSentryWebpackPluginConfig); |
There was a problem hiding this comment.
Lol "sentrified"
(We should make this a thing!)
| afterAll(() => { | ||
| rimraf.sync(TEMP_DIR_PATH); | ||
| }); |
There was a problem hiding this comment.
Wait, if I register a (before|after)(Each|All) call outside a describe closure, does that mean it runs for all tests in this directory?
If yes, that's totally fine, I just haven't seen this before, which is why I'm asking
There was a problem hiding this comment.
Nope, it only runs for the tests which import the file containing it. Neat, huh?
Honestly, before yesterday I didn't know that, either. I knew you could have a (before|after)(Each|All) call outside a describe in the same file (so, module level), but not that it could be in a totally separate file. But I took a flier and it ended up working out! (I tested it by logging inside the afterAll() function, and it only logged three times, once from inside of each file importing mocks.ts.)
There was a problem hiding this comment.
Interesting, but makes sense! Thanks for explaining!
In anticipation of adding more tests for the code in
src/configin the nextjs SDK, this breaks up the (very long) single file which had been covering the entire directory into multiple files, extracting some mocks, fixtures, and utils along they way into helper modules.The entire test suite could probably stand to be revisited/cleaned up, but for now this just distributes things into different files.