test(remix): Add server-side instrumentation integration tests. #5538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Aug 8, 2022
| assertSentryTransaction(transaction, { | ||
| spans: [ | ||
| { | ||
| description: 'routes/action-json-response/$id', |
There was a problem hiding this comment.
We should really think about if we can make this name better.
There was a problem hiding this comment.
Maybe something like `${action | loader | documentRequest} of ${route}`?
There was a problem hiding this comment.
Yeah I like that, even if the info is a bit redundant
onurtemizkan
force-pushed
the
onur/remix-server-integration-tests
branch
from
9eebad8 to
3ba64c2
Compare
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/remix-server-integration-tests
branch
7 times, most recently
from
4bd95b7 to
12488fa
Compare
onurtemizkan
force-pushed
the
onur/remix-server-integration-tests
branch
from
12488fa to
f29c0f0
Compare
AbhiPrasad
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic set of tests to ensure
loader,actionanddocumentRequestfunctions are properly instrumented.Also, switches
node-integration-testutilities to useaxiosto simulate requests, instead ofhttppackage, to easily switch betweenpostandgetrequests.