Skip to content

fix(ember): Speed up ember scenarios #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Aug 5, 2022

It is running the scenarios in sequence, running them in parallel might speed up the builds a bit.

k-fish added 2 commits August 5, 2022 15:41
It is running the scenarios in sequence, running them in parallel might speed up the builds a bit.
@k-fish k-fish requested review from a team, lforst and AbhiPrasad and removed request for a team August 5, 2022 20:59
@k-fish
Copy link
Member Author

k-fish commented Aug 5, 2022

This will hopefully drop times a bit, the setup seems to be where most the time is taking so this might be an Amdahl problem with installing reqs.

@lobsterkatie
Copy link
Member

the setup seems to be where most the time is taking so this might be an Amdahl problem with installing reqs.

Correct me if I'm wrong, but I think part of why this is so slow is that it's running yarn on the entire monorepo in order to change ember versions. Is there a way for the test app to have a separate package.json from the main @sentry/ember one, so that it could be more restricted in its scope?

@k-fish
Copy link
Member Author

k-fish commented Aug 5, 2022

running yarn on the entire monorepo

Yeah I'm pretty sure you're right. I'll take a look.

@AbhiPrasad
Copy link
Member

@k-fish for now gonna merge this in cause of the perf improvements - we can take a look at more efficiently running yarn at a later point.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) August 8, 2022 13:32
@AbhiPrasad AbhiPrasad merged commit 524fb6e into master Aug 8, 2022
@AbhiPrasad AbhiPrasad deleted the fix/ember-test-speed-up branch August 8, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants