chore: add trace to CONSOLE_LEVELS #5249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
vladanpaunovic
commented
Jun 10, 2022
| @@ -81,9 +81,9 @@ describe('CaptureConsole setup', () => { | |||
| expect(global.console.error).not.toBe(originalConsole.error); | |||
| expect(global.console.log).not.toBe(originalConsole.log); | |||
| expect(global.console.assert).not.toBe(originalConsole.assert); | |||
| expect(global.console.trace).not.toBe(originalConsole.trace); | |||
There was a problem hiding this comment.
As a result of adding trace to CONSOLE_LEVELS, we are now monkeypatching everything but console.table.
I am not sure whether we want this or not. I would appreciate someone double-checking this.
Also, why are we not monkeypathcing console.table as well?
There was a problem hiding this comment.
Yeah we want this. Don't know why we're not using table, but there are a few things to consider: 1. it has sort of a different API than the other methods 2. No IE11 support
lforst
approved these changes
Jun 10, 2022
|
For next time: We should have made this a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).closes #3946
fixes #4599