ref: Add back client reporting to BrowserClient
#5018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
commented
Apr 29, 2022
| IS_DEBUG_BUILD && logger.log(`Sending outcomes:\n${JSON.stringify(outcomes, null, 2)}`); | ||
|
|
||
| const url = getEnvelopeEndpointWithUrlEncodedAuth(this._dsn, this._options.tunnel); | ||
| const envelope = createClientReportEnvelope(outcomes, this._options.tunnel && dsnToString(this._dsn)); |
There was a problem hiding this comment.
It was like this before but I'm very unsure whether the && in this line should actually be a ||.
There was a problem hiding this comment.
It was based on this logic:
size-limit report 📦
|
AbhiPrasad
approved these changes
Apr 29, 2022
Base automatically changed from
lforst-add-track-client-reports-in-baseclient
to
7.x
April 29, 2022 15:52
lforst
force-pushed
the
lforst-send-client-reports-browser-client
branch
from
b87aa41 to
9527ceb
Compare
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back the sending of client reports in the browser client.
Ref: https://getsentry.atlassian.net/browse/WEB-775