chore(dev): Update ts-node to 10.7
#4976
Conversation
size-limit report 📦
|
lobsterkatie
force-pushed
the
kmclb-update-ts-node-to-10.7
branch
from
f845175 to
feb11ab
Compare
There was a problem hiding this comment.
Generally looks good to me. However, is there a reason we need to Upgrade?
Also: ts-node@10 seems to have node minimum version 12 - wondering if this is relevant.
I'll be totally honest, at this point I'd have to downgrade again and test everything out to know for sure. I upgraded as part of debugging a problem I was having with one of the new scripts for the build process, but I can't say for dead sure now whether it was necessary for the eventual fix. Either way, once I'd done the work to get the upgrade going, it seemed silly to roll it back, since we'll have to upgrade eventually in any case.
Good detective work. My guess is that either a) it's a YMMV situation, where it's not incompatible but they don't want to be held to making it work with Node 10 or b) whatever part of it is incompatible with Node 10 isn't a part we're using. For now the Node 10 tests are passing, and since it's a dev dependency, we have total control of how it and our SDK interact (and we know for sure it's not going to break a customer's build). If something comes up where it turns into a problem, we can always roll back to version 9 for the Node 10 tests the way we roll back to version 8 for the Node 8 tests. (Not meaning to dismiss either concern - they're valid questions! But in this case I think both are okay.) |
This updates `ts-node` to latest, and adds a command to the Node 8 test setup to downgrade it again, for compatibility. (Unlike the other downgrading of packages for Node 8 and 10 tests, this has to happen outside of our `test.ts` script, because it's the thing that's running that script in the first place.)
This updates `ts-node` to latest, and adds a command to the Node 8 test setup to downgrade it again, for compatibility. (Unlike the other downgrading of packages for Node 8 and 10 tests, this has to happen outside of our `test.ts` script, because it's the thing that's running that script in the first place.)
This updates `ts-node` to latest, and adds a command to the Node 8 test setup to downgrade it again, for compatibility. (Unlike the other downgrading of packages for Node 8 and 10 tests, this has to happen outside of our `test.ts` script, because it's the thing that's running that script in the first place.)
This updates `ts-node` to latest, and adds a command to the Node 8 test setup to downgrade it again, for compatibility. (Unlike the other downgrading of packages for Node 8 and 10 tests, this has to happen outside of our `test.ts` script, because it's the thing that's running that script in the first place.)
This updates
ts-nodeto latest, and adds a command to the Node 8 test setup to downgrade it again, for compatibility. (Unlike the other downgrading of packages for Node 8 and 10 tests, this has to happen outside of ourtest.tsscript, because it's the thing that's running that script in the first place.)