-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ci: Dont upload artifacts for non-release related runs #4728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea and it will for sure save some time. I have a question though: when this PR is merged, is there still a way of checking that the artifacts archive is created correctly? For example, I when I was doing the build
dir change (#4688) it was helpful for me to download and inspect the artifacts file. Found out that I was initially uploading more JS files than just the bundles.
You can name your branch |
I see. Given that we probably won't need to check artifacts generation often, I think that's a good change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change!
You can also, in your branch, change this condition to include the branch's name and then just drop the commit which does so before the PR is finalized. (I find that easier than keeping track of branches named something other than what I'd expect.) |
That's a good idea as well, thanks 👍 |
Saves us time and resources.