Skip to content

ci: Dont upload artifacts for non-release related runs #4728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

kamilogorek
Copy link
Contributor

Saves us time and resources.

@kamilogorek kamilogorek requested review from a team, lforst and Lms24 and removed request for a team March 17, 2022 09:29
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (72aed62) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.49 KB 19.49 KB +0.01% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 62.17 KB 62.17 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.11 KB 18.11 KB -0.01% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 55.5 KB 55.5 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.41 KB 22.41 KB 0%
@sentry/browser - Webpack (minified) 76.82 KB 76.82 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.45 KB 22.45 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.62 KB 46.62 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.36 KB 25.36 KB 0%
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.72 KB 23.72 KB +0.01% 🔺

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea and it will for sure save some time. I have a question though: when this PR is merged, is there still a way of checking that the artifacts archive is created correctly? For example, I when I was doing the build dir change (#4688) it was helpful for me to download and inspect the artifacts file. Found out that I was initially uploading more JS files than just the bundles.

@kamilogorek
Copy link
Contributor Author

is there still a way of checking that the artifacts archive is created correctly?

You can name your branch release/testing-artifacts or anything with release/ prefix and it will run the workflow just as you'd be running it when publishing new version (without actually triggering new version build).

@Lms24
Copy link
Member

Lms24 commented Mar 17, 2022

I see. Given that we probably won't need to check artifacts generation often, I think that's a good change.

@kamilogorek kamilogorek merged commit 250a911 into master Mar 17, 2022
@kamilogorek kamilogorek deleted the prevent-upload-nonrelease branch March 17, 2022 10:51
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@lobsterkatie
Copy link
Member

You can name your branch release/testing-artifacts or anything with release/ prefix and it will run the workflow just as you'd be running it when publishing new version (without actually triggering new version build).

You can also, in your branch, change this condition to include the branch's name and then just drop the commit which does so before the PR is finalized. (I find that easier than keeping track of branches named something other than what I'd expect.)

@Lms24
Copy link
Member

Lms24 commented Mar 17, 2022

That's a good idea as well, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants