Skip to content

fix(dev): Use correct schema for GHA workflow files in VSCode #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

lobsterkatie
Copy link
Member

VSCode has a feature wherein it auto-detects what schema to use to validate certain JSON and yml files. The problem is, sometimes it's wrong, and when it is, it will throw errors* because it's misconstrued what kind of file you're editing. The incorrect association can be overridden, though, with a correct association in settings.

This PR adds such an association, to prevent VSCode from complaining about our GHA build workflow.

*It correctly detects that it's a GHA config, but also checks it against the schema for a different build tool called hammerkit, and throws errors because the two schemas (schemae?) are incompatible, as can be seen here:

image

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (72aed62) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.49 KB 19.49 KB 0%
@sentry/browser - ES5 CDN Bundle (minified) 62.17 KB 62.17 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.11 KB 18.12 KB +0.02% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 55.5 KB 55.5 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.41 KB 22.41 KB 0%
@sentry/browser - Webpack (minified) 76.82 KB 76.82 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.45 KB 22.45 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.62 KB 46.62 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.36 KB 25.36 KB 0%
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.72 KB 23.72 KB +0.01% 🔺

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me!

@lobsterkatie lobsterkatie merged commit f7e2796 into master Mar 17, 2022
@lobsterkatie lobsterkatie deleted the kmclb-fix-gha-schemas-in-vscode branch March 17, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants