Skip to content

ref(build): Handle minification in rollup config generation function #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 7, 2022
Merged

ref(build): Handle minification in rollup config generation function #4681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
48a454e
remove unused exports from main rollup config
lobsterkatie Mar 3, 2022
30a0058
move license plugin to main rollup config
lobsterkatie Mar 3, 2022
bfe8570
add array helper functions
lobsterkatie Mar 3, 2022
2fb3db5
add function for creating minification config variants
lobsterkatie Mar 3, 2022
89e7314
use minification variant function in individual packages
lobsterkatie Mar 3, 2022
c823589
move comments describing types of configs
lobsterkatie Mar 3, 2022
6b30492
s/markAsBrowserBuild/markAsBrowserBuildPlugin
lobsterkatie Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 3 additions & 23 deletions packages/browser/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,17 @@
import { makeBaseBundleConfig, makeLicensePlugin, terserPlugin } from '../../rollup.config';
import { makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';

const builds = [];

const licensePlugin = makeLicensePlugin();

['es5', 'es6'].forEach(jsVersion => {
const baseBundleConfig = makeBaseBundleConfig({
input: 'src/index.ts',
isAddOn: false,
jsVersion,
licenseTitle: '@sentry/browser',
outputFileBase: `build/bundle${jsVersion === 'es6' ? '.es6' : ''}`,
});

builds.push(
...[
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.js`,
},
plugins: [...baseBundleConfig.plugins, licensePlugin],
},
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.min.js`,
},
plugins: [...baseBundleConfig.plugins, terserPlugin, licensePlugin],
},
],
);
builds.push(...makeMinificationVariants(baseBundleConfig));
});

export default builds;
58 changes: 19 additions & 39 deletions packages/integrations/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,45 +2,25 @@ import * as fs from 'fs';

import commonjs from '@rollup/plugin-commonjs';

import { makeBaseBundleConfig, terserPlugin } from '../../rollup.config';

function allIntegrations() {
return fs.readdirSync('./src').filter(file => file != 'index.ts');
}

function loadAllIntegrations() {
const builds = [];

allIntegrations().forEach(file => {
const baseBundleConfig = makeBaseBundleConfig({
input: `src/${file}`,
isAddOn: true,
jsVersion: 'es5',
outputFileBase: `build/${file.replace('.ts', '')}`,
});

[
{
extension: '.js',
plugins: [...baseBundleConfig.plugins, commonjs()],
},
{
extension: '.min.js',
plugins: [...baseBundleConfig.plugins, commonjs(), terserPlugin],
},
].forEach(build => {
builds.push({
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}${build.extension}`,
},
plugins: build.plugins,
});
});
import { insertAt, makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';

const builds = [];

const integrationSourceFiles = fs.readdirSync('./src').filter(file => file != 'index.ts');

integrationSourceFiles.forEach(file => {
const baseBundleConfig = makeBaseBundleConfig({
input: `src/${file}`,
isAddOn: true,
jsVersion: 'es5',
licenseTitle: '@sentry/integrations',
outputFileBase: `build/${file.replace('.ts', '')}`,
});

return builds;
}
// TODO We only need `commonjs` for localforage (used in the offline plugin). Once that's fixed, this can come out.
baseBundleConfig.plugins = insertAt(baseBundleConfig.plugins, -2, commonjs());

builds.push(...makeMinificationVariants(baseBundleConfig));
});

export default loadAllIntegrations();
export default builds;
26 changes: 3 additions & 23 deletions packages/tracing/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,17 @@
import { makeBaseBundleConfig, makeLicensePlugin, terserPlugin } from '../../rollup.config';
import { makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';

const builds = [];

const licensePlugin = makeLicensePlugin('@sentry/tracing & @sentry/browser');

['es5', 'es6'].forEach(jsVersion => {
const baseBundleConfig = makeBaseBundleConfig({
input: 'src/index.bundle.ts',
isAddOn: false,
jsVersion,
licenseTitle: '@sentry/tracing & @sentry/browser',
outputFileBase: `build/bundle.tracing${jsVersion === 'es6' ? '.es6' : ''}`,
});

builds.push(
...[
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.js`,
},
plugins: [...baseBundleConfig.plugins, licensePlugin],
},
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.min.js`,
},
plugins: [...baseBundleConfig.plugins, terserPlugin, licensePlugin],
},
],
);
builds.push(...makeMinificationVariants(baseBundleConfig));
});

export default builds;
24 changes: 3 additions & 21 deletions packages/vue/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,11 @@
import { makeBaseBundleConfig, makeLicensePlugin, terserPlugin } from '../../rollup.config';

const licensePlugin = makeLicensePlugin();
import { makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';

const baseBundleConfig = makeBaseBundleConfig({
input: 'src/index.bundle.ts',
isAddOn: false,
jsVersion: 'es5',
licenseTitle: '@sentry/vue',
outputFileBase: 'build/bundle.vue',
});

export default [
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.js`,
},
plugins: [...baseBundleConfig.plugins, licensePlugin],
},
{
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}.min.js`,
},
plugins: [...baseBundleConfig.plugins, terserPlugin, licensePlugin],
},
];
export default makeMinificationVariants(baseBundleConfig);
29 changes: 3 additions & 26 deletions packages/wasm/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,11 @@
import { makeBaseBundleConfig, terserPlugin } from '../../rollup.config';
import { makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';

const baseBundleConfig = makeBaseBundleConfig({
input: 'src/index.ts',
isAddOn: true,
jsVersion: 'es5',
licenseTitle: '@sentry/wasm',
outputFileBase: 'build/wasm',
});

function loadAllIntegrations() {
const builds = [];
[
{
extension: '.js',
plugins: baseBundleConfig.plugins,
},
{
extension: '.min.js',
plugins: [...baseBundleConfig.plugins, terserPlugin],
},
].forEach(build => {
builds.push({
...baseBundleConfig,
output: {
...baseBundleConfig.output,
file: `${baseBundleConfig.output.file}${build.extension}`,
},
plugins: build.plugins,
});
});
return builds;
}

export default loadAllIntegrations();
export default makeMinificationVariants(baseBundleConfig);
Loading