Skip to content

Revert "feat(browser): Track measure detail as span attributes" #16348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented May 20, 2025

It seems like this change introduced a problem where accessing event.detail causes a DOMException to be thrown (only on firefox?). This is causing the SDK to crash if someone has tracing enabled. Until we figure out a reproduction and a more formal fix (with some e2e tests) let's revert the problematic PR and move forward.

Reverts #16240

ref #16347

@AbhiPrasad AbhiPrasad requested a review from a team May 20, 2025 18:47
@AbhiPrasad AbhiPrasad self-assigned this May 20, 2025
@AbhiPrasad AbhiPrasad requested review from stephanie-anderson and s1gr1d and removed request for a team May 20, 2025 18:47
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.95 kB - -
@sentry/browser - with treeshaking flags 23.71 kB - -
@sentry/browser (incl. Tracing) 38.27 kB -0.25% -95 B 🔽
@sentry/browser (incl. Tracing, Replay) 76.38 kB -0.12% -86 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.49 kB -0.14% -92 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 81.16 kB -0.12% -90 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 93.25 kB -0.11% -100 B 🔽
@sentry/browser (incl. Feedback) 40.72 kB - -
@sentry/browser (incl. sendFeedback) 28.67 kB - -
@sentry/browser (incl. FeedbackAsync) 33.56 kB - -
@sentry/react 25.73 kB - -
@sentry/react (incl. Tracing) 40.24 kB -0.23% -92 B 🔽
@sentry/vue 28.34 kB - -
@sentry/vue (incl. Tracing) 40.09 kB -0.26% -102 B 🔽
@sentry/svelte 23.97 kB - -
CDN Bundle 25.23 kB - -
CDN Bundle (incl. Tracing) 38.37 kB -0.38% -146 B 🔽
CDN Bundle (incl. Tracing, Replay) 74.23 kB -0.09% -63 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 79.66 kB -0.12% -88 B 🔽
CDN Bundle - uncompressed 73.63 kB - -
CDN Bundle (incl. Tracing) - uncompressed 113.66 kB -0.33% -367 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 227.63 kB -0.17% -367 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.45 kB -0.16% -367 B 🔽
@sentry/nextjs (client) 41.9 kB -0.22% -90 B 🔽
@sentry/sveltekit (client) 38.74 kB -0.25% -95 B 🔽
@sentry/node 149.47 kB - -
@sentry/node - without tracing 98.1 kB - -
@sentry/aws-serverless 123.43 kB - -

View base workflow run

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) May 20, 2025 18:59
@AbhiPrasad AbhiPrasad merged commit acc6fe1 into develop May 20, 2025
126 checks passed
@AbhiPrasad AbhiPrasad deleted the revert-16240-abhi-performance-measure-detail branch May 20, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants