test(react-router): Add and fix tests for pre rendered routes #16346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RulaKhaled
changed the title
RulaKhaled
changed the title
chargome
approved these changes
May 21, 2025
dev-packages/e2e-tests/test-applications/react-router-7-framework/react-router.config.ts
Outdated
Show resolved
Hide resolved
| test('should send pageload transaction for prerendered pages', async ({ page }) => { | ||
| const txPromise = waitForTransaction(APP_NAME, async transactionEvent => { | ||
| return transactionEvent.transaction === '/performance/static'; | ||
| return transactionEvent.transaction === '/performance/static/'; |
…ork/react-router.config.ts Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
❌ Unsupported file format
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was confirmed that static pre-renders don't pick up Sentry trace meta tags — this just adds a quick test.
More context: https://linear.app/getsentry/issue/JS-392/rr7-evaluate-static-pre-rendering
P.S. Not a priority, but for some reason, I had to add a trailing / to fetch the correct transactions and pass the tests. I’ll look into why this is happening for transaction route names and whether this behavior is expected in a later PR.