feat(node): Rewrite absolute stackframes by default

dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts

@@ -18,7 +18,10 @@ describe('ContextLines integration in ESM', () => {
                 stacktrace: {
                   frames: expect.arrayContaining([
                     {
-                      filename: expect.stringMatching(/\/scenario with space.mjs$/),
+                      filename: '/suites/contextLines/filename-with-spaces/scenario with space.mjs',
+                      abs_path: expect.stringContaining(
+                        '/dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/scenario with space.mjs',
+                      ),
                       context_line: "Sentry.captureException(new Error('Test Error'));",
                       pre_context: ["import * as Sentry from '@sentry/node';", ''],
                       post_context: ['', '// some more post context'],
@@ -54,7 +57,10 @@ describe('ContextLines integration in CJS', () => {
                 stacktrace: {
                   frames: expect.arrayContaining([
                     {
-                      filename: expect.stringMatching(/\/scenario with space.cjs$/),
+                      filename: '/suites/contextLines/filename-with-spaces/scenario with space.cjs',
+                      abs_path: expect.stringContaining(
+                        '/dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/scenario with space.cjs',
+                      ),
                       context_line: "Sentry.captureException(new Error('Test Error'));",
                       pre_context: [
                         '',

dev-packages/node-integration-tests/suites/public-api/captureException/catched-error/test.ts

@@ -21,6 +21,10 @@ test('should work inside catch block', async () => {
               stacktrace: {
                 frames: expect.arrayContaining([
                   expect.objectContaining({
+                    filename: '/suites/public-api/captureException/catched-error/scenario.ts',
+                    abs_path: expect.stringContaining(
+                      '/dev-packages/node-integration-tests/suites/public-api/captureException/catched-error/scenario.ts',
+                    ),
                     context_line: "  throw new Error('catched_error');",
                     pre_context: [
                       'Sentry.init({',

dev-packages/node-integration-tests/suites/public-api/captureException/simple-error/test.ts

@@ -19,7 +19,14 @@ test('should capture a simple error with message', async () => {
                 handled: true,
               },
               stacktrace: {
-                frames: expect.any(Array),
+                frames: expect.arrayContaining([
+                  expect.objectContaining({
+                    filename: '/suites/public-api/captureException/simple-error/scenario.ts',
+                    abs_path: expect.stringContaining(
+                      '/dev-packages/node-integration-tests/suites/public-api/captureException/simple-error/scenario.ts',
+                    ),
+                  }),
+                ]),
               },
             },
           ],

packages/core/src/integrations/rewriteframes.ts

@@ -54,7 +54,7 @@ interface RewriteFramesOptions {
  */
 export const rewriteFramesIntegration = defineIntegration((options: RewriteFramesOptions = {}) => {
   const root = options.root;
-  const prefix = options.prefix || 'app:///';
+  const prefix = options.prefix ?? 'app:///';
 
   const isBrowser = 'window' in GLOBAL_OBJ && !!GLOBAL_OBJ.window;
 
@@ -137,13 +137,15 @@ export function generateIteratee({
       }
     } else {
       if (isWindowsFrame || startsWithSlash) {
+        const abs_path = frame.filename;
         const filename = isWindowsFrame
-          ? frame.filename
+          ? abs_path
               .replace(/^[a-zA-Z]:/, '') // remove Windows-style prefix
               .replace(/\\/g, '/') // replace all `\\` instances with `/`
-          : frame.filename;
+          : abs_path;
         const base = root ? relative(root, filename) : basename(filename);
         frame.filename = `${prefix}${base}`;
+        frame.abs_path = abs_path;
       }
     }
 

packages/core/test/lib/integrations/rewriteframes.test.ts

@@ -139,6 +139,16 @@ describe('RewriteFrames', () => {
       expect(event.exception!.values![0]?.stacktrace!.frames![0]?.filename).toEqual('foobar/file1.js');
       expect(event.exception!.values![0]?.stacktrace!.frames![1]?.filename).toEqual('foobar/file2.js');
     });
+
+    it('handles empty string as prefix', () => {
+      rewriteFrames = rewriteFramesIntegration({
+        prefix: '',
+      });
+
+      const event = rewriteFrames.processEvent?.(exceptionEvent, {}, {} as any) as Event;
+      expect(event.exception!.values![0]?.stacktrace!.frames![0]?.filename).toEqual('file1.js');
+      expect(event.exception!.values![0]?.stacktrace!.frames![1]?.filename).toEqual('file2.js');
+    });
   });
 
   describe('default iteratee appends basename to `app:///` if frame starts with Windows path prefix', () => {

packages/node/src/sdk/index.ts

@@ -11,6 +11,7 @@ import {
   logger,
   propagationContextFromHeaders,
   requestDataIntegration,
+  rewriteFramesIntegration,
   stackParserFromStackParserOptions,
 } from '@sentry/core';
 import {
@@ -69,6 +70,11 @@ export function getDefaultIntegrationsWithoutPerformance(): Integration[] {
     nodeContextIntegration(),
     childProcessIntegration(),
     processSessionIntegration(),
+    // This has to run after the other integrations, because it rewrites the frames
+    rewriteFramesIntegration({
+      root: process.cwd(),
+      prefix: '/',
+    }),
     ...getCjsOnlyIntegrations(),
   ];
 }

packages/sveltekit/test/server-common/rewriteFramesIntegration.test.ts

@@ -45,6 +45,7 @@ describe('rewriteFramesIteratee', () => {
 
     expect(result.exception?.values?.[0]?.stacktrace?.frames?.[0]).toEqual({
       filename: 'app:///3-ab34d22f.js',
+      abs_path: '/some/path/to/server/chunks/3-ab34d22f.js',
       lineno: 1,
       colno: 1,
     });