feat(react-router): Create a Vite plugin that injects sentryConfig into the global vite config #16197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
changed the title
|
Could you just add a sentence to the PR description what this does (for the changelog) and open a pr in our docs repo? |
|
RulaKhaled
added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 8, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Should document changes made in getsentry/sentry-javascript#16197 TL;DR: Users no longer need to pass SentryOptions to the Vite global config—this is now handled under the hood by the React Router Vite plugin. <img width="762" alt="Screenshot 2025-05-06 at 10 44 20 AM" src="https://github.com/user-attachments/assets/e7618662-dcc2-45c0-abed-c4c71a259762" /> ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15520
Add a new plugin
makeConfigInjectorPluginwithin our existing vite plugin that updates the global vite config with sentry optionsyarn lint) & (yarn test).