Skip to content

ref(node): Streamline check for adding performance integrations #15021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 15, 2025

Noticed that we had this check which is redundant since we changed the hasTracingEnabled behavior.

@mydea mydea requested review from Lms24 and s1gr1d January 15, 2025 08:10
@mydea mydea self-assigned this Jan 15, 2025
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.82 KB - -
@sentry/browser - with treeshaking flags 21.5 KB - -
@sentry/browser (incl. Tracing) 35.5 KB - -
@sentry/browser (incl. Tracing, Replay) 72.27 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.78 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.53 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.54 KB - -
@sentry/browser (incl. Feedback) 39.06 KB - -
@sentry/browser (incl. sendFeedback) 27.46 KB - -
@sentry/browser (incl. FeedbackAsync) 32.25 KB - -
@sentry/react 25.54 KB - -
@sentry/react (incl. Tracing) 38.26 KB - -
@sentry/vue 26.95 KB - -
@sentry/vue (incl. Tracing) 37.23 KB - -
@sentry/svelte 22.97 KB - -
CDN Bundle 24.14 KB - -
CDN Bundle (incl. Tracing) 35.84 KB - -
CDN Bundle (incl. Tracing, Replay) 70.46 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 75.6 KB - -
CDN Bundle - uncompressed 70.4 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.04 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 216.87 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 229.4 KB - -
@sentry/nextjs (client) 38.38 KB - -
@sentry/sveltekit (client) 36.03 KB - -
@sentry/node 161.22 KB -0.02% -32 B 🔽
@sentry/node - without tracing 97.04 KB +0.01% +1 B 🔺
@sentry/aws-serverless 126.91 KB +0.01% +1 B 🔺

View base workflow run

@mydea mydea merged commit 4ed0e69 into develop Jan 15, 2025
113 checks passed
@mydea mydea deleted the fn/remove-unneeded-check branch January 15, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants