Skip to content

feat(core)!: Remove TransactionNamingScheme type #14865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/migration/v8-to-v9.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ Sentry.init({
- The `urlEncode` method has been removed. There is no replacement.
- The `getDomElement` method has been removed. There is no replacement.
- The `Request` type has been removed. Use `RequestEventData` type instead.
- The `TransactionNamingScheme` type has been removed. There is no replacement.
- The `memoBuilder` method has been removed. There is no replacement.

### `@sentry/browser`
Expand Down
6 changes: 1 addition & 5 deletions packages/core/src/utils-hoist/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,7 @@ export {
extractQueryParamsFromUrl,
headersToDict,
} from './requestdata';
export type {
AddRequestDataToEventOptions,
// eslint-disable-next-line deprecation/deprecation
TransactionNamingScheme,
} from './requestdata';
export type { AddRequestDataToEventOptions } from './requestdata';

export { severityLevelFromString } from './severity';
export {
Expand Down
7 changes: 1 addition & 6 deletions packages/core/src/utils-hoist/requestdata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export type AddRequestDataToEventOptions = {
request?: boolean | Array<(typeof DEFAULT_REQUEST_INCLUDES)[number]>;
/** @deprecated This option will be removed in v9. It does not do anything anymore, the `transcation` is set in other places. */
// eslint-disable-next-line deprecation/deprecation
transaction?: boolean | TransactionNamingScheme;
transaction?: boolean | 'path' | 'methodPath' | 'handler';
user?: boolean | Array<(typeof DEFAULT_USER_INCLUDES)[number]>;
};

Expand All @@ -54,11 +54,6 @@ export type AddRequestDataToEventOptions = {
};
};

/**
* @deprecated This type will be removed in v9. It is not in use anymore.
*/
export type TransactionNamingScheme = 'path' | 'methodPath' | 'handler';

/**
* Extracts a complete and parameterized path from the request object and uses it to construct transaction name.
* If the parameterized transaction name cannot be extracted, we fall back to the raw URL.
Expand Down
Loading