Skip to content

ref: Remove unnecessary checks for SpanJSON.data existence #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 16, 2024

Since this was reworked in #14693 to always return something, we can safe some checks/fallbacks.

This most likely does not change all the things, but focuses on the places that were easy to find/replace.

@mydea mydea requested review from lforst and chargome December 16, 2024 13:53
@mydea mydea self-assigned this Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.23 KB -0.01% -2 B 🔽
@sentry/browser - with treeshaking flags 21.9 KB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing) 35.74 KB -0.02% -5 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.99 KB -0.01% -4 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.39 KB -0.02% -7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 77.39 KB -0.01% -6 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.78 KB -0.01% -5 B 🔽
@sentry/browser (incl. Feedback) 39.99 KB -0.01% -1 B 🔽
@sentry/browser (incl. sendFeedback) 27.83 KB -0.01% -2 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.62 KB -0.01% -2 B 🔽
@sentry/react 25.93 KB -0.01% -2 B 🔽
@sentry/react (incl. Tracing) 38.6 KB -0.02% -5 B 🔽
@sentry/vue 27.47 KB -0.01% -2 B 🔽
@sentry/vue (incl. Tracing) 37.61 KB -0.03% -9 B 🔽
@sentry/svelte 23.39 KB -0.02% -4 B 🔽
CDN Bundle 24.39 KB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing) 37.46 KB -0.01% -2 B 🔽
CDN Bundle (incl. Tracing, Replay) 72.54 KB -0.01% -5 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.92 KB -0.01% -5 B 🔽
CDN Bundle - uncompressed 71.63 KB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 111 KB -0.02% -14 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.05 KB -0.01% -14 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.26 KB -0.01% -14 B 🔽
@sentry/nextjs (client) 38.85 KB -0.02% -6 B 🔽
@sentry/sveltekit (client) 36.28 KB -0.02% -7 B 🔽
@sentry/node 162.77 KB -0.06% -95 B 🔽
@sentry/node - without tracing 99 KB -0.03% -21 B 🔽
@sentry/aws-serverless 126.72 KB -0.02% -22 B 🔽

View base workflow run

@mydea mydea force-pushed the fn/span-data-checks branch 3 times, most recently from 323a7d7 to fc069ff Compare December 16, 2024 15:58
Since this was reworked to always return something, we can safe some checks/fallbacks.
@mydea mydea force-pushed the fn/span-data-checks branch 2 times, most recently from d0758a2 to 759cad9 Compare December 16, 2024 17:14
@mydea mydea merged commit f862dd6 into develop Dec 17, 2024
158 checks passed
@mydea mydea deleted the fn/span-data-checks branch December 17, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants