Skip to content

feat(node)!: Remove fine grained registerEsmLoaderHooks option and addOpenTelemetryInstrumentation() #14606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 19, 2024
Merged

feat(node)!: Remove fine grained registerEsmLoaderHooks option and addOpenTelemetryInstrumentation() #14606

merged 14 commits into from
Dec 19, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Dec 6, 2024

Resolves #14332

mydea and others added 2 commits December 6, 2024 10:27
@mydea
ci(v9): Ensure CI runs on v8 & v9 branches (#14604)
7846b24 
In order for us to have size-limit comparison etc, we need to ensure CI
runs on v8 & v9 branches too.
@lforst @mydea
feat(node)!: Remove fine grained registerEsmLoaderHooks option and …
22d1f96 
…`addOpenTelemetryInstrumentation()`
@mydea mydea force-pushed the lforst-esm-loader-updates-v9 branch from b46cf67 to 22d1f96 Compare December 6, 2024 10:34
@mydea mydea requested a review from timfish December 6, 2024 10:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.29 KB - -
@sentry/browser - with treeshaking flags 21.96 KB - -
@sentry/browser (incl. Tracing) 35.79 KB - -
@sentry/browser (incl. Tracing, Replay) 73.03 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.41 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.45 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.83 KB - -
@sentry/browser (incl. Feedback) 40.04 KB - -
@sentry/browser (incl. sendFeedback) 27.89 KB - -
@sentry/browser (incl. FeedbackAsync) 32.68 KB - -
@sentry/react 25.96 KB - -
@sentry/react (incl. Tracing) 38.6 KB - -
@sentry/vue 27.49 KB - -
@sentry/vue (incl. Tracing) 37.62 KB - -
@sentry/svelte 23.45 KB - -
CDN Bundle 24.43 KB - -
CDN Bundle (incl. Tracing) 37.46 KB - -
CDN Bundle (incl. Tracing, Replay) 72.55 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.94 KB - -
CDN Bundle - uncompressed 71.74 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.05 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.1 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.31 KB - -
@sentry/nextjs (client) 38.87 KB - -
@sentry/sveltekit (client) 36.29 KB - -
@sentry/node 162.71 KB -0.03% -49 B 🔽
@sentry/node - without tracing 98.84 KB -0.06% -51 B 🔽
@sentry/aws-serverless 126.48 KB -0.13% -156 B 🔽

View base workflow run

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
249 1 248 8
View the top 1 failed tests by shortest run time 
basic.test.ts AWS Serverless SDK sends events in ESM mode
Stack Traces | 2.13s run time 
basic.test.ts:5:5 AWS Serverless SDK sends events in ESM mode

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@lforst lforst requested a review from mydea December 10, 2024 12:14
mydea and others added 3 commits December 11, 2024 13:26
@mydea
ci(v9): Ensure CI runs on v8 & v9 branches (#14604)
6610144 
In order for us to have size-limit comparison etc, we need to ensure CI
runs on v8 & v9 branches too.
@lforst @mydea
feat(vue/nuxt)!: No longer create "update" spans for component trac…
1648698 
…king by default (#14602)

Resolves #12851
@lforst @mydea
feat(nextjs)!: Remove experimental_captureRequestError (#14607)
d9ee102 
Fixes #14302
@timfish
Copy link
Collaborator

timfish commented Dec 11, 2024

Here is a fix for import-in-the-middle to support the absolute path used in the aws lambda instrumentation:

@mydea mydea force-pushed the v9 branch 2 times, most recently from 7bf602c to f792e64 Compare December 13, 2024 12:38
@timfish
Copy link
Collaborator

timfish commented Dec 17, 2024

v1.12.0 of import-in-the-middle has been released which should fix the issues here!

@lforst lforst mentioned this pull request Dec 19, 2024
Merged
@lforst lforst merged commit e190793 into v9 Dec 19, 2024
137 checks passed
@lforst lforst deleted the lforst-esm-loader-updates-v9 branch December 19, 2024 13:14
@lforst lforst mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
ci-skip-cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lforst @timfish @mydea