ref: Refactor some more any types
#14546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
approved these changes
Dec 3, 2024
| @@ -78,8 +78,7 @@ export class ServerRuntimeClient< | |||
| /** | |||
| * @inheritDoc | |||
| */ | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| public captureException(exception: any, hint?: EventHint, scope?: Scope): string { | |||
| public captureException(exception: unknown, hint?: EventHint, scope?: Scope): string { | |||
There was a problem hiding this comment.
I think this might be breaking in a weird way but I can't think of an example right now.
There was a problem hiding this comment.
this should be fine as accepting stuff as unknown like this will generally work for anything. The problematic part is replacing a return value of any with unknown, or with function args taking ...args: unknown[] vs ...args: any[].
Lms24
reviewed
Dec 3, 2024
Comment on lines
+173
to
+174
| const colno = column; | ||
| const lineno = line; |
There was a problem hiding this comment.
m: why are we removing the isNaN check here?
There was a problem hiding this comment.
because it should not actually be needed, I think? window.onerror = function() should be supported everywhere in all the browser we support, and is typed consistently, so these should be proper numbers (or undefined) always?
AbhiPrasad
approved these changes
Dec 3, 2024
mydea
force-pushed
the
fn/refactor-some-more-any
branch
from
6d45ce7 to
bc0b5d3
Compare
mydea
force-pushed
the
fn/refactor-some-more-any
branch
from
bc0b5d3 to
11bcde2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of some more
anytypes.