-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(browser): Remove getLocalTestPath
in favor of getLocalTestUrl
#14331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
5de5673
to
2f3ad9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just one thing, getLocalTestUrl
always adds routes for allowing lazy loading of feedback, maybe we want to make this opt-in? Not sure if it actually has any (performance) impact on our tests.
Hmm we could make it opt-in I suppose! Will check it out. |
2f3ad9f
to
04cdcc7
Compare
04cdcc7
to
3c9e578
Compare
size-limit report 📦
|
1c04dbf
to
de26ef5
Compare
de26ef5
to
8cd4133
Compare
Using a proper URL-based setup in browser integration tests instead of serving from a file makes the tests more realistic, as chrome behavior can differ slightly in those scenarios.
I refactored any tests that required actual changes in a previous PR, so this PR does:
getLocalTestPath
withgetLocalTestUrl
getLocalTestPath
test fixture