deps(nextjs): Bump @rollup/plugin-commonjs #14250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
changed the title
lforst
approved these changes
Nov 13, 2024
mydea
reviewed
Nov 13, 2024
| @@ -79,7 +79,7 @@ | |||
| "@opentelemetry/api": "^1.9.0", | |||
| "@opentelemetry/instrumentation-http": "0.53.0", | |||
| "@opentelemetry/semantic-conventions": "^1.27.0", | |||
| "@rollup/plugin-commonjs": "26.0.1", | |||
There was a problem hiding this comment.
just to clarify, are there no breaking changes here that affect us (e.g. node version support etc)?
There was a problem hiding this comment.
I didn't find anything, theres no changelog etc. so I relied on our own tests here
There was a problem hiding this comment.
This stuff is thoroughly tested.
There was a problem hiding this comment.
oh, there is actually one: https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md
just wasn't in the package itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14249