Skip to content

test: Remove explict casting of baseconfig in vite configs #12979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

AbhiPrasad
Copy link
Member

Something I noticed while doing my jest -> vitest conversions, we don't need this anymore.

@AbhiPrasad AbhiPrasad requested a review from a team July 18, 2024 14:23
@AbhiPrasad AbhiPrasad self-assigned this Jul 18, 2024
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner July 18, 2024 14:23
@AbhiPrasad AbhiPrasad requested review from mydea and s1gr1d and removed request for a team July 18, 2024 14:23
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 18, 2024 18:11
@AbhiPrasad AbhiPrasad merged commit cf6eb01 into develop Jul 18, 2024
118 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-vitest-config-spread-test branch July 18, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants