fix(nuxt): Add module to build:transpile script #12843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
commented
Jul 10, 2024
Comment on lines
+31
to
+42
| What is working: | ||
|
|
||
| - Error Reporting | ||
|
|
||
| What is partly working: | ||
|
|
||
| - Tracing by setting `tracesSampleRate` | ||
|
|
||
| What is not yet(!) included: | ||
|
|
||
| - Source Maps | ||
| - Connected Traces |
There was a problem hiding this comment.
I will add a more detailed description later. Just wanted to fix the module folder output right now and add some basic information along the way.
Lms24
approved these changes
Jul 10, 2024
lforst
reviewed
Jul 10, 2024
| @@ -84,10 +84,12 @@ | |||
| "build:transpile": { | |||
| "dependsOn": [ | |||
| "^build:transpile", | |||
| "^build:types" | |||
| "^build:types", | |||
| "build:types" | |||
There was a problem hiding this comment.
Transpilation usually shouldn't depend on the same packages types. Is there a reason you added this?
There was a problem hiding this comment.
This is because I am building the module with nuxt-module-build and this already relies on the types. I am getting the build warning Potential missing package.json files: build/types/index.types.d.ts if there are no types yet.
This was referenced Aug 7, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
modulefolder to the build output when building packages in root-level.