Skip to content

feat(node): Allow to pass instrumentation config to httpIntegration #12761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 4, 2024

Today, it is not (easily) possible to use custom config for the OTEL HttpInstrumentation. We depend on our own integration for various things, so overwriting this will lead to lots of problems.

With this PR, you can now pass some config through directly, in an "allowlisted" way, + there is an escape hatch to add arbitrary other config:

Sentry.init({
  integrations: [
    Sentry.httpIntegration({ instrumentation: {
      // these three are "vetted"
      requestHook: (span, req) => span.setAttribute('custom', req.method),
      responseHook: (span, res) => span.setAttribute('custom', res.method),
      applyCustomAttributesOnSpan: (span, req, res) => span.setAttribute('custom', req.method),
      // escape hatch: Can add arbitrary other config that is passed through
      _experimentalConfig: {
        serverName: 'xxx'
      }
    })
  ]
});

Closes #12672

@mydea mydea requested review from lforst and AbhiPrasad July 4, 2024 12:37
@mydea mydea self-assigned this Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

size-limit report 📦

Path Size
@sentry/browser 22.28 KB (0%)
@sentry/browser (incl. Tracing) 33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.85 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.71 KB (0%)
@sentry/browser (incl. metrics) 26.57 KB (0%)
@sentry/browser (incl. Feedback) 38.92 KB (0%)
@sentry/browser (incl. sendFeedback) 26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.51 KB (0%)
@sentry/react 25.02 KB (0%)
@sentry/react (incl. Tracing) 36.48 KB (0%)
@sentry/vue 26.39 KB (0%)
@sentry/vue (incl. Tracing) 35.29 KB (0%)
@sentry/svelte 22.41 KB (0%)
CDN Bundle 23.49 KB (0%)
CDN Bundle (incl. Tracing) 35.18 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.28 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.47 KB (0%)
CDN Bundle - uncompressed 68.94 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.96 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.35 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.06 KB (0%)
@sentry/nextjs (client) 36.35 KB (0%)
@sentry/sveltekit (client) 34.07 KB (0%)
@sentry/node 130.8 KB (+0.06% 🔺)
@sentry/node - without tracing 91.83 KB (+0.09% 🔺)
@sentry/aws-serverless 117 KB (+0.07% 🔺)

@mydea mydea force-pushed the fn/http-integration-options branch from d37def1 to 28a397f Compare July 5, 2024 07:05
@mydea mydea merged commit a2dcb28 into develop Jul 5, 2024
102 of 103 checks passed
@mydea mydea deleted the fn/http-integration-options branch July 5, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom @opentelemetry/instrumentation-http config
2 participants