Skip to content

fix(tests): Update the expected status on 404. #12483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

onurtemizkan
Copy link
Collaborator

Updates the expected status message for 404 span reflecting the updates in #12477

@onurtemizkan onurtemizkan force-pushed the onur/fix-node-tests branch from ae68fa8 to a19e837 Compare June 13, 2024 14:09
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.04 KB (0%)
@sentry/browser (incl. Tracing) 33.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.95 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.27 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.02 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.17 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.01 KB (+0.04% 🔺)
@sentry/browser (incl. metrics) 26.23 KB (0%)
@sentry/browser (incl. Feedback) 38.24 KB (+0.08% 🔺)
@sentry/browser (incl. sendFeedback) 26.63 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.18 KB (0%)
@sentry/react 24.81 KB (0%)
@sentry/react (incl. Tracing) 36.27 KB (0%)
@sentry/vue 26.05 KB (0%)
@sentry/vue (incl. Tracing) 35.08 KB (0%)
@sentry/svelte 22.17 KB (0%)
CDN Bundle 23.39 KB (0%)
CDN Bundle (incl. Tracing) 34.91 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.02 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.15 KB (0%)
CDN Bundle - uncompressed 68.71 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.3 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 213.75 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.21 KB (0%)
@sentry/nextjs (client) 35.63 KB (0%)
@sentry/sveltekit (client) 33.86 KB (0%)
@sentry/node 111.96 KB (-0.01% 🔽)
@sentry/node - without tracing 89.43 KB (-0.01% 🔽)
@sentry/aws-serverless 98.49 KB (-0.01% 🔽)

@onurtemizkan onurtemizkan requested review from mydea and AbhiPrasad June 13, 2024 14:18
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just noticed that, wonder why that wasn't caught in that PR? :O

@mydea
Copy link
Member

mydea commented Jun 13, 2024

Ah, I think the opentelemetry package is missing in the node dependencies for CI... will add!

@mydea mydea merged commit 091cd3a into develop Jun 13, 2024
85 checks passed
@mydea mydea deleted the onur/fix-node-tests branch June 13, 2024 14:30
@mydea
Copy link
Member

mydea commented Jun 13, 2024

See: #12484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants