chore(e2e): Reduce solid e2e tests flakines by waiting for more speci… #12455
Conversation
| @@ -3,7 +3,7 @@ import { waitForError } from '@sentry-internal/test-utils'; | |||
|
|
|||
| test('captures an exception', async ({ page }) => { | |||
| const errorEventPromise = waitForError('solid', errorEvent => { | |||
| return !errorEvent.type; | |||
| return !errorEvent.type && errorEvent.transaction === '/error-boundary-example'; | |||
There was a problem hiding this comment.
Ideally you find a very specific way to wait for events, as they may leak between tests.
There was a problem hiding this comment.
Any ideas? I can only think of creating a different route per test.
There was a problem hiding this comment.
different route per test
I think this is what we usually do 😬 another option would be to configure playwright to only sequentially run tests but it's also not ideal...
There was a problem hiding this comment.
The leaking I had happened between the errorboundary tests and the normal error tests, and there the transaction field is different. Maybe we can leave it as is for now and see if there's more flakiness to fix later?
There was a problem hiding this comment.
You can also set tags or contexts in the tests and assert on them!
No description provided.