Skip to content

docs(sveltekit): Vite plugin rewording #11743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

docs(sveltekit): Vite plugin rewording #11743

merged 1 commit into from
Apr 23, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 23, 2024

"...which is a dependency of the SvelteKit SDK" could also be understood as "you need this as additional dependency"

@s1gr1d s1gr1d requested a review from Lms24 April 23, 2024 07:21
Lms24
Lms24 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this - your version is definitely less confusing for users 😅

@s1gr1d s1gr1d merged commit e955925 into develop Apr 23, 2024
@s1gr1d s1gr1d deleted the sig/svektekit-vite-plugin-docs branch April 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s1gr1d @Lms24