test(e2e): Fix node E2E test app #11682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Apr 18, 2024
| .toBe(200); | ||
| }); | ||
|
|
||
| test('Sends correct error event', async ({ baseURL }) => { |
Lms24
approved these changes
Apr 18, 2024
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into how we send trace context for error events (today: We only send
trace_id,span_idandparent_span_idfor errors, while we send everything for transactions. In browser, we always send everything...) I noticed that we don't cover this well for express today. Digging into this, I figured the tests was actually pretty broken, because we didn't have the right import order, so instrumentation was not fully correct 😬 so I split the node-express E2E tests into multiple files, added a test to check the error event shape, and fixed the app setup.