Skip to content

fix: Missing ErrorEvent export are added to node, browser, bun, deno, vercel-edge sub-packages #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AndreyTheWeb
Copy link
Contributor

@AndreyTheWeb AndreyTheWeb commented Apr 17, 2024

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Since I am only using the browser and node sub-packages, I modified only those folders. If other packages also needs to be updated, let me know.

@AndreyTheWeb AndreyTheWeb changed the base branch from master to develop April 17, 2024 10:34
@AbhiPrasad
Copy link
Member

Could you export it from the following packages as well?

const DEPENDENTS: Dependent[] = [
{
package: '@sentry/astro',
compareWith: nodeExports,
exports: Object.keys(SentryAstro),
ignoreExports: [
// Not needed for Astro
'setupFastifyErrorHandler',
],
},
{
package: '@sentry/bun',
compareWith: nodeExports,
exports: Object.keys(SentryBun),
ignoreExports: [
// not supported in bun:
'NodeClient',
],
},
{
package: '@sentry/nextjs',
compareWith: nodeExports,
// Next.js doesn't require explicit exports, so we can just merge top level and `default` exports:
// @ts-expect-error: `default` is not in the type definition but it's defined
exports: Object.keys({ ...SentryNextJs, ...SentryNextJs.default }),
},
{
package: '@sentry/remix',
compareWith: nodeExports,
exports: Object.keys(SentryRemix),
},
{
package: '@sentry/aws-serverless',
compareWith: nodeExports,
exports: Object.keys(SentryAWS),
ignoreExports: [
// Not needed for Serverless
'setupFastifyErrorHandler',
],
},
{
package: '@sentry/google-cloud-serverless',
compareWith: nodeExports,
exports: Object.keys(SentryGoogleCloud),
ignoreExports: [
// Not needed for Serverless
'setupFastifyErrorHandler',
],
},
{
package: '@sentry/sveltekit',
compareWith: nodeExports,
exports: Object.keys(SentrySvelteKit),
},
];

Thanks for opening a PR!

@AndreyTheWeb
Copy link
Contributor Author

@AbhiPrasad yes, I'll do it now

@AndreyTheWeb
Copy link
Contributor Author

@AbhiPrasad I added export to other libraries where it was required. The rest are re-exported from @sentry/node

@AndreyTheWeb AndreyTheWeb changed the title fix: Missing ErrorEvent export are added to node and browser sub-packages fix: Missing ErrorEvent export are added to node, browser, bun, deno, vercel-edge sub-packages Apr 17, 2024
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AbhiPrasad AbhiPrasad merged commit bd526ab into getsentry:develop Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants