doc: Add clarifying comment for hub on ACS #11633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Apr 16, 2024
Lms24
approved these changes
Apr 16, 2024
Comment on lines
138
to
139
| // Eventually we may change this if/when we update the loader to not require this field anymore | ||
| const sentry = getSentryCarrier(registry) as { hub?: AsyncContextStack }; |
There was a problem hiding this comment.
we should probably link to the other pice of the puzzle: https://github.com/getsentry/sentry-javascript/blob/f1c4611c551816ca2fad537a6b5a17ead1b75b16/packages/core/src/sdk.ts/#L50-L62
Suggested change
| // Eventually we may change this if/when we update the loader to not require this field anymore | |
| const sentry = getSentryCarrier(registry) as { hub?: AsyncContextStack }; | |
| // Eventually we may change this if/when we update the loader to not require this field anymore | |
| // Related, we also write to `hub` in {@link ./sdk.ts registerClientOnGlobalHub} | |
| const sentry = getSentryCarrier(registry) as { hub?: AsyncContextStack }; |
There was a problem hiding this comment.
which reminds me that the comment in the linked code is also a bit outdated with the renaming in #11630
There was a problem hiding this comment.
good point, I updated stuff to point correctly to other places!
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a comment for #11630 (comment)!