Skip to content

ci(canary): Fix canary tests #11502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
Merged

ci(canary): Fix canary tests #11502

merged 1 commit into from
Apr 9, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 9, 2024

Fixes the Canary tests by ensuring we cache node modules and files in dev-packages as well.

In the debugging process, I also moved a few things around - e.g. the playwright dependency stuff now happens in CI, not in the build commands everywhere.

@mydea mydea requested review from lforst and s1gr1d April 9, 2024 08:48
@mydea mydea self-assigned this Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

size-limit report 📦

Path Size
@sentry/browser 22.1 KB (0%)
@sentry/browser (incl. Tracing) 31.71 KB (0%)
@sentry/browser (incl. Tracing, Replay) 66.92 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.52 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.75 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 75.67 KB (0%)
@sentry/browser (incl. Feedback) 30.87 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 30.88 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 30.89 KB (0%)
@sentry/browser (incl. sendFeedback) 26.88 KB (0%)
@sentry/react 24.78 KB (0%)
@sentry/react (incl. Tracing) 34.61 KB (0%)
@sentry/vue 25.53 KB (0%)
@sentry/vue (incl. Tracing) 33.44 KB (0%)
@sentry/svelte 22.23 KB (0%)
CDN Bundle 24.11 KB (0%)
CDN Bundle (incl. Tracing) 32.66 KB (0%)
CDN Bundle (incl. Tracing, Replay) 66.37 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 71.63 KB (0%)
CDN Bundle - uncompressed 71.67 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 97.71 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 207.1 KB (0%)
@sentry/nextjs (client) 33.8 KB (0%)
@sentry/sveltekit (client) 32.24 KB (0%)
@sentry/node 120.05 KB (+0.1% 🔺)

@mydea mydea force-pushed the fn/canary-e2e-install branch from c861800 to 07eef1a Compare April 9, 2024 13:40
@mydea mydea merged commit 1c47e57 into develop Apr 9, 2024
@mydea mydea deleted the fn/canary-e2e-install branch April 9, 2024 13:56
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Fixes the Canary tests by ensuring we cache node modules and files in
dev-packages as well.

In the debugging process, I also moved a few things around - e.g. the
playwright dependency stuff now happens in CI, not in the build commands
everywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants