Skip to content

ref(core): Remove startTransaction & finishTransaction hooks #11008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 11, 2024

This refactors the remaining usage of startTransaction and finishTransaction hooks (most of it in tests), and removes these hooks.

This is on top of #11007

@mydea mydea requested review from lforst, Lms24, AbhiPrasad and s1gr1d March 11, 2024 11:24
@mydea mydea self-assigned this Mar 11, 2024
Base automatically changed from fn/browser-profiling-hooks to develop March 11, 2024 14:17
@mydea mydea force-pushed the fn/avoid-transaction-hooks branch from 5bd5b0d to 73aae9b Compare March 11, 2024 14:21
@mydea mydea marked this pull request as ready for review March 11, 2024 14:26
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insanely satisfying

@mydea mydea force-pushed the fn/avoid-transaction-hooks branch from 04a0c5c to c5a30c7 Compare March 11, 2024 15:01
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mydea mydea merged commit eaee46f into develop Mar 11, 2024
@mydea mydea deleted the fn/avoid-transaction-hooks branch March 11, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants