Skip to content

feat(node): Rephrase wording in http integration JSDoc #10947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2024
Merged

feat(node): Rephrase wording in http integration JSDoc #10947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcded3a
feat(node): untrue comment in source code #9211
edem-cyber Mar 6, 2024
ee2dd5c
Merge branch 'develop' into node-package-docs-typo-https-file
edem-cyber Mar 7, 2024
2b85367
Reword a bit and add description to new integration
Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/node-experimental/src/integrations/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ const _httpIntegration = ((options: HttpOptions = {}) => {
};
}) satisfies IntegrationFn;

/**
* The http integration instruments Node's internal http and https modules.
* It creates breadcrumbs and spans for outgoing HTTP requests which will be attached to the currently active span.
*/
export const httpIntegration = defineIntegration(_httpIntegration);

/** Update the span with data we need. */
Expand Down
4 changes: 2 additions & 2 deletions packages/node/src/integrations/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ const _httpIntegration = ((options: HttpIntegrationOptions = {}) => {
export const httpIntegration = defineIntegration(_httpIntegration);

/**
* The http module integration instruments Node's internal http module. It creates breadcrumbs, transactions for outgoing
* http requests and attaches trace data when tracing is enabled via its `tracing` option.
* The http integration instruments Node's internal http and https modules.
* It creates breadcrumbs and spans for outgoing HTTP requests which will be attached to the currently active span.
*
* @deprecated Use `httpIntegration()` instead.
*/
Expand Down